Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up auth documentation #763

Merged
merged 2 commits into from
Jun 7, 2016
Merged

Cleaned up auth documentation #763

merged 2 commits into from
Jun 7, 2016

Conversation

jwngr
Copy link

@jwngr jwngr commented Jun 7, 2016

Resolves #759 and #760. I also realized a ton of other things in the docs had the wrong signature or were named incorrectly, so I tried cleaning up as much of that as I could. I pretty much read through every auth-related thing and tried to get it updated.

| `provider` | The authentication method used (e.g. "anonymous" or "google.com"). |
| `token` | The contents of the authentication token (an OpenID JWT). |

The contents of `auth.token` will further contain the following information:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

further

@katowulf
Copy link
Contributor

katowulf commented Jun 7, 2016

A couple nits to consider. Bin if they are annoying.

@katowulf katowulf assigned jwngr and unassigned katowulf Jun 7, 2016
@jwngr
Copy link
Author

jwngr commented Jun 7, 2016

Back to you @katowulf.

@jwngr jwngr assigned katowulf and unassigned abeisgoat and jwngr Jun 7, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.412% when pulling e11cd28 on jw-auth-fixes into 4bf90a1 on master.

@katowulf
Copy link
Contributor

katowulf commented Jun 7, 2016

☃☃☃ Are we waiting on Abe to lgtm? If not, merge away.

@katowulf katowulf assigned jwngr and unassigned katowulf Jun 7, 2016
@jwngr jwngr merged commit df49c20 into master Jun 7, 2016
@jwngr jwngr deleted the jw-auth-fixes branch June 7, 2016 19:26
@jwngr
Copy link
Author

jwngr commented Jun 7, 2016

Nope, just needed either of you. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants