Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Mail not synced to MailChimp after linking email credentials #19

Closed
kristijandraca opened this issue Sep 28, 2019 · 6 comments
Closed
Assignees
Labels
type: feature request New feature or request

Comments

@kristijandraca
Copy link

[READ] Step 1: Are you in the right place?

Yes.

[REQUIRED] Step 2: Describe your configuration

  • Extension name: auth-mailchimp-sync

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

  1. Create anonymous user
  2. Link email credential to that user
Expected result

An email address from email credential should sync to MailChimp.

Actual result

Did not sync.

@Ehesp
Copy link
Member

Ehesp commented Sep 29, 2019

Currently the function only runs on user create, rather than an update. Will have to check whether this is possible via triggers.

@Ehesp
Copy link
Member

Ehesp commented Sep 30, 2019

Unfortunately this isn't possible at the moment, as the UserBuilder for functions only provides onCreate and onDelete handlers: https://firebase.google.com/docs/reference/functions/functions.auth.UserBuilder

@kristijandraca
Copy link
Author

Ok, but this leaves this plugin pretty much unusable since it won't update email on linking credential, and another big situation, is when the user decides to change his email.

@rafikhan rafikhan changed the title [BUG] Mali not synced to MailChimp after linking email credentials [BUG] Mail not synced to MailChimp after linking email credentials Oct 2, 2019
@rphlmr
Copy link

rphlmr commented Oct 16, 2019

In case we store user profiles in a collection (name, mail, uid), is it possible to imagine an option for the "update" trigger of this extension ?

@Ehesp Ehesp added the type: feature request New feature or request label Oct 16, 2019
@Ehesp
Copy link
Member

Ehesp commented Oct 16, 2019

Let me bring this one up with the team. Generally it would be a totally different extension if it triggered on collection change. Here's something which may work:

  1. Auth user create: Updates Mailchimp + creates a record in a collection, with an email.
  2. If a users email changes (via manual update on the users part), this automatically removes the email and updates Mailchimp with the new one.

This does however totally change the flow so it'll need some discussion. Thanks!

cc @karayu

@karayu
Copy link
Contributor

karayu commented Nov 12, 2019

Thanks so much for the feature request! It sounds like this would need to be a new extension.

Do you mind filing a feature request for this so we can track it?
https://firebase.google.com/support/troubleshooter/report/features/

I'm closing this issue for now since it's unfortunately not a change to the current extension.

@karayu karayu closed this as completed Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants