Import context from golang.org/x/net

[tbpg]

[REQUIRED] Step 2: Describe your environment

• Operating System version: N/A
• Firebase SDK version: N/A
• Library version: Master
• Firebase Product: all

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

What happened? How can we make the problem occur?
This could be a description, log/console output, etc.

go version 1.6
go get -u firebase.google.com/go

Log from a failed Travis build:

get "firebase.google.com/go": found meta tag main.metaImport{Prefix:"firebase.google.com/go", VCS:"git", RepoRoot:"https://github.com/firebase/firebase-admin-go"} at https://firebase.google.com/go?go-get=1
firebase.google.com/go (download)
package context: unrecognized import path "context" (import path does not begin with hostname)

https://travis-ci.org/GoogleCloudPlatform/golang-samples/jobs/351066691#L1064

Relevant Code:

import "context" should be import "golang.org/x/net/context".

This is mentioned in the v.2.5.0 changelog, but looks like there are some references remaining: https://github.com/firebase/firebase-admin-go/search?utf8=%E2%9C%93&q=context&type=.

This is blocking GoogleCloudPlatform/golang-samples#418.

I'll work on a PR.

[google-oss-bot]

Hmmm this issue does not seem to follow the issue template. Make sure you provide all the required information.

[google-oss-bot]

Hey there! I couldn't figure out what this issue is about, so I've labeled it for a human to triage. Hang tight.

[mbleigh]

I believe Go 1.6 is not supported by the Firebase Admin SDK. @hiranya911 to confirm.

[hiranya911]

Correct. We never really supported 1.6 properly, and starting from last release we officially dropped 1.6 support: #101

Our documentation might be a little behind with regard to this change. I'll iron those our in the next few days.

[tbpg]

Any way to revisit that decision? I have a PR ready which brings back compatibility.

Go 1.6 is still available in AppEngine, which we need to support in https://github.com/GoogleCloudPlatform/golang-samples/. In particular, I'm working on extending https://cloud.google.com/appengine/docs/standard/go/building-app/ to support authentication and it would be great to be able to use Firebase.

[hiranya911]

Why not use golang1.8 in App Engine? Given that Go no longer supports anything older than 1.9 (see https://golang.org/doc/devel/release.html), it seems unnecessary to support something as old as 1.6.

[tbpg]

AppEngine Standard still has 1.6 available.

[hiranya911]

That is true, but developers can choose 1.8 when using Firebase. Is there any reason that takes that choice out of the picture?

[tbpg]

Some users are stuck on older versions of Go without an easy ability to upgrade. So, for https://github.com/GoogleCloudPlatform/golang-samples/, we support all possible versions of Go.

[hiranya911]

In #98 we found that the Admin SDK never really supported Go 1.6. What's interesting is that we didn't hear about this from any users. We discovered it ourselves while setting up CI for Go 1.6. So I think it's fair to assume that all Admin SDK users are already on Go 1.7 or higher. Given that, and all the internal discussions we've had on this topic, I'm reluctant to go back.

But if you're willing to provide a PR, with the necessary code changes and a working Travis config for 1.6, then we can revisit this.

[tbpg]

Thank you, Hiranya! I appreciate it. I opened #119 and #120.