chore: adds missing provider IDs for Auth #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing token claims `sign_in_provider` values.
hiranya911
approved these changes
Dec 3, 2020
| * "yahoo.com"`, `"phone"`, `"playgames.google.com"`, `"gc.apple.com"`, | ||
| * or `"custom"`. | ||
| * | ||
| * Additional Identity Platform provider IDs include `"linkedin.com"`, |
There was a problem hiding this comment.
Should linkedin be listed in the previous paragraph? Why was it mentioned separately?
There was a problem hiding this comment.
LinkedIn is only available via the cloud console UI at the moment. Though I don't believe it is restricted to GCIP. In theory it could be enabled via REST API for Firebase. I can move it to above but worry Firebase developers may get confused when they don't see it there.
kevinthecheung
approved these changes
Dec 8, 2020
BorntraegerMarc
pushed a commit
to BorntraegerMarc/firebase-admin-node
that referenced
this pull request
Jan 28, 2021
Adds missing token claims `sign_in_provider` values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing token claims
sign_in_providervalues.Fixes #1101