Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a logger module to integrate with Cloud Logging #79

Closed
jhuleatt opened this issue May 3, 2023 · 2 comments · Fixed by #121
Closed

Add a logger module to integrate with Cloud Logging #79

jhuleatt opened this issue May 3, 2023 · 2 comments · Fixed by #121
Labels
feature-request New feature or request

Comments

@jhuleatt
Copy link
Contributor

jhuleatt commented May 3, 2023

Create a Python equivalent of the Node logger subpackage to integrate with Cloud Logging's structured logs

Also include trace; https://github.com/firebase/firebase-functions/blob/aae1abd55930550636e8e95c41feefcb617edc9d/src/common/trace.ts#L6

@jhuleatt jhuleatt changed the title Logger module Add a logger module to integrate with Cloud Logging May 3, 2023
@russellwheatley russellwheatley added the feature-request New feature or request label Jul 10, 2023
@ekalosak
Copy link
Contributor

Why not just format stdout logging as a valid UTF-8 JSON string? This is what I'm using and Cloud logging picks it up and parses it automatically. I wonder what value an additional module would be?
Screen Shot 2023-09-11 at 11 08 40 AM

@exaby73
Copy link
Contributor

exaby73 commented Sep 22, 2023

@ekalosak #121 does print JSON which is parsed by GCP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants