Fixing threading-related hang during initialization in urgent mode #11216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Report 1Affected ProductsTest Logs |
|
I resolved the problem that led to the SPM test failure. #10958 (comment) |
samedson
force-pushed
the
samedson/wowlocal-urgent-deadlock
branch
3 times, most recently
from
06e64b6
to
dcf324c
Compare
samedson
force-pushed
the
samedson/wowlocal-urgent-deadlock
branch
from
dcf324c
to
bf0b680
Compare
|
@wowlocal this should be a good way to solve the problem. Thank you very much for your contribution! I was able to use that unit test to reproduce the issue. After removing the fix the test fails, and now it passes. Going to merge this once my teammate approves. |
themiswang
approved these changes
May 31, 2023
|
Great fix! I'm glad the test was helpful 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modification of #10958
Paired on with @wowlocal
Rotating the Installation ID when uploading in Urgent Mode is not necessary, so this modifies the previous PR to skip rotating the Installation ID when we have the conditions for deadlock.
One problem with this seems to be the isMainThread check. Dispatch Queues in the background are not guaranteed to run in a background thread, so I believe the isMainThread check is true even when run on a background dispatch_queue. This seems to over-count cases where this could deadlock.