Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Add - (void)setNumberOfStackFramesToSkipForNotFatalErrors:(NSUInteger)frames to Crashlytics #11475

Open
paulz opened this issue Jun 26, 2023 · 2 comments

Comments

@paulz
Copy link

paulz commented Jun 26, 2023

Description

  1. When reporting non-fatal error to Crashlytics we use our helper class to enable testing
  2. This cause errors to be shown with same title on our dashboard.
    See non-fatal errors shown with same text when calling indirectly #11474
  3. Proposal:
    1. add method to set number of stack trace frames to be skipped, e.g. - (void)setNumberOfStackFramesToSkipForNotFatalErrors:(NSUInteger)frames
    2. remove given number of frames from error stack trace when reporting

API Proposal

@interface FIRCrashlytics
- (void)setNumberOfStackFramesToSkipForNotFatalErrors:(NSUInteger)frames;
@end

Firebase Product(s)

Crashlytics

@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@paulz
Copy link
Author

paulz commented Jun 26, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants