Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs unnecessarily undergo limbo resolution while resuming query bug #12044

Merged
merged 10 commits into from Nov 22, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Nov 2, 2023

@google-oss-bot
Copy link

google-oss-bot commented Nov 2, 2023

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.09% (146dea0) to 88.15% (3371911) by +0.07%.

    FilenameBase (146dea0)Merge (3371911)Diff
    exception.cc23.68%84.21%+60.53%
    leveldb_key.cc98.82%98.14%-0.69%
    leveldb_mutation_queue.cc92.42%93.56%+1.14%
    leveldb_remote_document_cache.cc96.55%94.83%-1.72%
    ordered_code.cc93.90%94.39%+0.49%
    sync_engine.cc95.26%95.34%+0.08%
    view.cc98.39%98.39%-0.01%
    write_stream.cc94.37%91.55%-2.82%
  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 60.44% (146dea0) to 60.52% (3371911) by +0.08%.

    FilenameBase (146dea0)Merge (3371911)Diff
    FIRMessagingCheckinPreferences.m93.07%98.02%+4.95%
  • FirebasePerformance-iOS-FirebasePerformance.framework

    Overall coverage changed from 94.71% (146dea0) to 94.76% (3371911) by +0.05%.

    FilenameBase (146dea0)Merge (3371911)Diff
    FPRGaugeManager.m95.42%97.39%+1.96%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0iq6Si9JNc.html

Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please just add a release notes entry.

Firestore/core/src/core/view.cc Show resolved Hide resolved
Firestore/core/src/core/view.h Outdated Show resolved Hide resolved
@dconeybe dconeybe assigned milaGGL and unassigned dconeybe Nov 16, 2023
@google-oss-bot
Copy link

google-oss-bot commented Nov 20, 2023

Size Report 1

Affected Products

  • FirebaseFirestore

    TypeBase (bbd2d09)Merge (3371911)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/etfYW6liVr.html

Firestore/core/src/core/view.h Outdated Show resolved Hide resolved
Firestore/core/src/core/view.h Outdated Show resolved Hide resolved
Firestore/core/src/core/view.h Outdated Show resolved Hide resolved
@milaGGL milaGGL merged commit e8cd98f into master Nov 22, 2023
56 checks passed
@milaGGL milaGGL deleted the mila/fix-limbo-bug branch November 22, 2023 14:57
@firebase firebase locked and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants