Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firestore] Remove DocumentID setter warning #12756

Merged
merged 2 commits into from Apr 17, 2024
Merged

[Firestore] Remove DocumentID setter warning #12756

merged 2 commits into from Apr 17, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Apr 11, 2024 •
edited

Passing a non-nil value to the @DocumentID property wrapper's setter no longer logs a warning.

  • This warning discouraged some valid programming patterns, e.g., updating a document ID field in a local Codable object after the document is created in Firestore.

@andrewheard andrewheard marked this pull request as ready for review April 11, 2024 19:22
@google-oss-bot
Copy link

google-oss-bot commented Apr 11, 2024 •
edited

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 40.71% (16f64bf) to 40.39% (7c5426e) by -0.32%.

    FilenameBase (16f64bf)Merge (7c5426e)Diff
    DocumentID.swift86.44%85.19%-1.26%

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.18% (16f64bf) to 88.19% (7c5426e) by +0.01%.

    FilenameBase (16f64bf)Merge (7c5426e)Diff
    leveldb_key.cc98.14%98.33%+0.20%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Q2CDRlQNon.html

peterfriese
peterfriese approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with the Vector Search codelab sample app, and it works fine.

Thanks!

@andrewheard andrewheard merged commit 9af2a9d into main Apr 17, 2024
54 checks passed
@andrewheard andrewheard deleted the ah/document-id-warning branch April 17, 2024 14:30
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request May 1, 2024
@cgrindel-self-hosted-renovate
chore(deps): update dependency firebase/firebase-ios-sdk to from: "10…
fc086f7 
….25.0" (#1056)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](https://togithub.com/firebase/firebase-ios-sdk)
| minor | `from: "10.24.0"` -> `from: "10.25.0"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v10.25.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.25.0):
Firebase Apple 10.25.0

[Compare
Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.24.0...10.25.0)

The Firebase Apple SDK (10.25.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.25.0)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

#### What's Changed

- \[FirebaseCoreInternal] Switch to implementation-only import of GULs
by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12714
- \[AppCheck, Database, InAppMessaging, MLModelDownloader, Performance,
Sessions] Migrate to GoogleUtilities's storage container by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[#&#8203;12752](https://togithub.com/firebase/firebase-ios-sdk/issues/12752),
[#&#8203;12753](https://togithub.com/firebase/firebase-ios-sdk/issues/12753),
[#&#8203;12757](https://togithub.com/firebase/firebase-ios-sdk/issues/12757),
[#&#8203;12759](https://togithub.com/firebase/firebase-ios-sdk/issues/12759),
[#&#8203;12762](https://togithub.com/firebase/firebase-ios-sdk/issues/12762),
[#&#8203;12773](https://togithub.com/firebase/firebase-ios-sdk/issues/12773)
- Use declspec in Firestore on Windows machines by
[@&#8203;a-maurice](https://togithub.com/a-maurice) in
[firebase/firebase-ios-sdk#12758
- \[CI] Stop Xcode 14, start Xcode 15.3 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[firebase/firebase-ios-sdk#12746
- \[Performance] Migrate to GoogleUtilities's storage container by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12759
- Todos and workarounds for tests not yet ready for macos-14 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[firebase/firebase-ios-sdk#12781
- Another macos-14 CI workaround by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[firebase/firebase-ios-sdk#12787
- \[CI] Update grpc dependent jobs to macos-14 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[firebase/firebase-ios-sdk#12790
- \[Firestore] Remove DocumentID setter warning by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[firebase/firebase-ios-sdk#12756
- \[App Check] Bump dependency on AppCheckCore to 10.19.0+ by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12806
- Allow Blob of data with zero length. by
[@&#8203;tom-andersen](https://togithub.com/tom-andersen) in
[firebase/firebase-ios-sdk#12694
- \[Infra] Switch zip building over to Xcode 15.2 by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12737
- Make use of
SQLITE_OPEN_FILEPROTECTION_COMPLETEUNTILFIRSTUSERAUTHENTICATION
conditional. by
[@&#8203;cprince-foreflight](https://togithub.com/cprince-foreflight) in
[firebase/firebase-ios-sdk#12548
- \[Release Tooling] Consistent approach to resources when building on
Xcode 15 by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12821
- \[Release Tooling] Cleanup unused folder references by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[firebase/firebase-ios-sdk#12825
- Analytics 10.25.0 by [@&#8203;pcfba](https://togithub.com/pcfba) in
[firebase/firebase-ios-sdk#12843
- Update `FIRAuthInterop` to use `_Nullable_result` annotation by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[firebase/firebase-ios-sdk#12841
- Disable quickstart CI that doesn't work with Xcode 15 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[firebase/firebase-ios-sdk#12846

#### New Contributors

- [@&#8203;mrs1669](https://togithub.com/mrs1669) made their first
contribution in
[firebase/firebase-ios-sdk#12760
- [@&#8203;a-maurice](https://togithub.com/a-maurice) made their first
contribution in
[firebase/firebase-ios-sdk#12758
- [@&#8203;cprince-foreflight](https://togithub.com/cprince-foreflight)
made their first contribution in
[firebase/firebase-ios-sdk#12548

**Full Changelog**:
firebase/firebase-ios-sdk@10.24.0...10.25.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@firebase firebase locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@peterfriese peterfriese peterfriese approved these changes

Assignees
No one assigned
Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewheard @google-oss-bot @paulb777 @peterfriese