Move Timestamp class from Firestore to Firebase Core

[cherylEnkidu]

Move Timestamp class into FirebaseCore. FirebaseFirestore.Timestamp was changed to FirebaseCore.Timestamp.

[github-actions]

Apple API Diff Report

Commit: ae746d4
Last updated: Fri Jul 12 12:29 PDT 2024
View workflow logs & download artifacts

---

[BUILD ERROR] FirebaseFirestore

---

FirebaseCore

Classes

[ADDED] FIRTimestamp

[ADDED] FIRTimestamp

Swift:
+  class Timestamp : NSObject , NSCopying
+    init ( seconds : Int64 , nanoseconds : Int32 )
+    convenience init ( date : Date )
+    convenience init ()
+    func dateValue () -> Date
+    func compare ( _ other : Timestamp ) -> ComparisonResult
+    var seconds : Int64 { get }
+    var nanoseconds : Int32 { get }
Objective-C:
+  @interface FIRTimestamp : NSObject < NSCopying >
+    - ( nonnull instancetype ) initWithSeconds :( int64_t ) seconds nanoseconds :( int32_t ) nanoseconds ;
+    + ( nonnull instancetype ) timestampWithSeconds :( int64_t ) seconds nanoseconds :( int32_t ) nanoseconds ;
+    + ( nonnull instancetype ) timestampWithDate :( nonnull NSDate * ) date ;
+    + ( nonnull instancetype ) timestamp ;
+    - ( nonnull NSDate * ) dateValue ;
+    - ( NSComparisonResult ) compare :( nonnull FIRTimestamp * ) other ;
+    @property ( nonatomic , readonly ) int64_t seconds ;
+    @property ( nonatomic , readonly ) int32_t nanoseconds ;

---

[BUILD ERROR] FirebaseFirestoreInternal

---

[google-oss-bot]

Coverage Report ¹

Affected Products

• FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

  Overall coverage changed from 88.21% (eca84fd) to 88.17% (056560a) by -0.04%.

  Filename	Base (eca84fd)	Merge (056560a)	Diff
  exception.cc	84.21%	23.68%	-60.53%
  leveldb_key.cc	98.63%	99.02%	+0.39%

Test Logs

• Base (eca84fd): https://github.com/firebase/firebase-ios-sdk/actions/runs/9768771643
• Merge (056560a): https://github.com/firebase/firebase-ios-sdk/actions/runs/9782147088

1. https://storage.googleapis.com/firebase-sdk-metric-reports/gML4LaVlPF.html

[paulb777]

Good to merge to main after July 8th.

It can merge to the release-11.0 branch before that.

[cherylEnkidu]

Good to merge to main after July 8th.

It can merge to the release-11.0 branch before that.

Hi @paulb777 , just want to double check, I can merge to main branch after July 8th?

[paulb777]

Yes - 10.29.0 is releasing and the release-11.0 branch has merged to main.

It looks like there are some conflicts. Let icore know if you have any questions about them.

[ncooke3]

FirebaseFirestore.Timestamp was changed to FirebaseCore.Timestamp.

@paulb777 – This is a small break, but I believe we could add:

@_exported import class FirebaseCore.Timestamp

to selectively import and re-export that class so it stills appears under the FirebaseFirestore namespace (like what was done with Swift extensions post-consolidation). This would make the move non-breaking.

[paulb777]

SGTM. It should minimize the break.

[cherylEnkidu]

Should I create a new PR to add this line in FirebaseFirestoreSwift.swift or there is a pr working in progress?

[ncooke3]

@cherylEnkidu, sure! I haven't started anything. For all the files in this PR where you needed to add import FirebaseCore, I think you should be able to just replace those with @_exported import class FirebaseCore.Timestamp.

[cherylEnkidu]

Got it, I will send you a PR shortly.