Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing warnings in XCode 10 GM #1846

Closed
fbandemer opened this issue Sep 19, 2018 · 21 comments
Closed

Signing warnings in XCode 10 GM #1846

fbandemer opened this issue Sep 19, 2018 · 21 comments
Assignees

Comments

@fbandemer
Copy link

Hello,
i get this warnings when using building my application with Xcode10 GM

  • "Skipping code signing because the target does not have an Info.plist file. (in target 'FirebaseCore')"
  • "Skipping code signing because the target does not have an Info.plist file. (in target 'FirebaseDatabase')"
  • "Skipping code signing because the target does not have an Info.plist file. (in target 'FirebaseMessaging')"

I've read several post in other forums to this issue but there seems to be no solution or workaround.

Environment

  • Xcode version: Xcode 10 GM
  • Firebase SDK version: 5.8.0
  • Firebase Component: Core, Database, Analytics, Messaging
  • Component version: Core(5.1.3),Database(5.0.3), Analytics(5.1.2), Messaging(3.1.1)

Steps to reproduce:

  1. Install Xcode 10 GM
  2. Init cocoapods
  3. Install firebase component via podfile
  4. Build the application
@alexeybolv
Copy link

Have the same issue after update to Xcode 10 in firebase sdk version 5.9.0

@paulb777 paulb777 assigned morganchen12 and unassigned ryanwilson Sep 26, 2018
@morganchen12
Copy link
Contributor

What versions of CocoaPods are you both using?

@alexeybolv
Copy link

What versions of CocoaPods are you both using?

I have 1.5.3 version.

@fbandemer
Copy link
Author

What versions of CocoaPods are you both using?

I have version 1.5.3 too.

@paulb777
Copy link
Member

We might need a Podfile and/or sample project to investigate. I haven't been able to repro with my sample.

@alexeybolv
Copy link

alexeybolv commented Sep 27, 2018

Here is my podfile

source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '11.0'

"#"ignore all warnings from all pods
inhibit_all_warnings!

target 'MyProject' do

use_frameworks!

pod 'Moya', '~> 11.0.2'
pod 'SDWebImage', '~> 4.4.2'
pod 'Firebase/Core', '~> 5.9.0'
pod 'Firebase/Messaging'
pod 'CSV.swift', '~> 2.2.1'

end

"#" Workaround for Cocoapods issue #7606
post_install do |installer|
    installer.pods_project.build_configurations.each do |config|
        config.build_settings.delete('CODE_SIGNING_ALLOWED')
        config.build_settings.delete('CODE_SIGNING_REQUIRED')
	if config.name == 'Release'
      		config.build_settings['SWIFT_OPTIMIZATION_LEVEL'] = '-Owholemodule'
    	else
      		config.build_settings['SWIFT_OPTIMIZATION_LEVEL'] = '-Onone'
   	end   
    end
end

@paulb777
Copy link
Member

paulb777 commented Oct 1, 2018

I'm still not able to reproduce. Are you able to make it happen in an example you can share - like one of the quickstarts? - https://github.com/firebase/quickstart-ios

@djradev
Copy link

djradev commented Oct 2, 2018

I also see the same issue after I executed $pod update (v. 1.5.3).

There is a warning in the following targets: FirebaseCore, FirebaseAuth, FirebaseDatabase, FirebaseDynamicLinks, FirebaseMessaging, FirebaseFirestore, FirebaseStorage.

Interestingly there isn't similar warning for targets like GoogleUtilities, which is a dependency for one of the above targets, I believe.

@paulb777
Copy link
Member

paulb777 commented Oct 2, 2018

It seems to be related to the pods that are static frameworks. Static frameworks should be linked into the app before code signing, so shouldn't be involved in any code signing scripts.

I'm still looking for an example.

@djradev
Copy link

djradev commented Oct 2, 2018

One more (potentially important) thing - I only see the warnings when I build for simulator, when I build for a device - no warnings

@paulb777 paulb777 assigned paulb777 and unassigned morganchen12 Oct 8, 2018
@paulb777
Copy link
Member

paulb777 commented Oct 8, 2018

I've reproduced and I'm investigating.

@paulb777
Copy link
Member

paulb777 commented Oct 8, 2018

A workaround is change to the old build system:

  • Open Xcode
  • Select File upper-left next to Apple icon
  • Open Workspace Settings
  • Change the build system to Legacy Build System

@Horoshaya
Copy link

Is it the best we can do to resolve this issue?

@paulb777
Copy link
Member

The issue is now fixed on CocoaPods master from CocoaPods/CocoaPods#8287 and is planned to be in whichever CocoaPods release follows 1.6.0.beta.2

@HizirDeveloper97579
Copy link

FireBase worning.pdf

@HizirDeveloper97579
Copy link

Вот решение этой проблемы
FireBase worning.pdf
FireBase.worning.pdf

@riley-usagi
Copy link

FireBase worning.pdf

Только - warning, а не worning =)

But thank you for answer.

@AgungLaksana
Copy link

Вот решение этой проблемы
FireBase worning.pdf
FireBase.worning.pdf

could you please help us little bit more? after clicking "Choose Info.plist file" button, then what info.plist that I have to choose ?

@AgungLaksana
Copy link

FireBase worning.pdf

Только - warning, а не worning =)

But thank you for answer.

is that worked? I am confused, what kind of info.plist that I have to choose after clicking that "Choose Info.plist file" button

@HizirDeveloper97579
Copy link

Я выбираю основной Info.plist ! Помоему он начинается non.info.plist .... Если я правильно запомнил

@riley-usagi
Copy link

FireBase worning.pdf

Только - warning, а не worning =)
But thank you for answer.

is that worked? I am confused, what kind of info.plist that I have to choose after clicking that "Choose Info.plist file" button

https://stackoverflow.com/questions/54367118/xcode-warning-skipping-code-signing-because-the-target-does-not-have-an-info-pl/54367150#54367150

@firebase firebase locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants