Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Build Firebase 5.15.0 binaries with Xcode 10.1 #2221

Closed
sraiteri opened this issue Dec 27, 2018 · 4 comments
Closed

FR: Build Firebase 5.15.0 binaries with Xcode 10.1 #2221

sraiteri opened this issue Dec 27, 2018 · 4 comments

Comments

@sraiteri
Copy link

sraiteri commented Dec 27, 2018

Environment

  • Xcode version: 10.1
  • Firebase SDK version: 5.15.0
  • Firebase Component: Analytics, Messaging
  • Component version: 5.15.0

Describe the problem

Working for a team that is heavily reliant on Carthage, the experimental Cartage for Firebase SDK components (binaries) has been greatly appreciated 😄.

We're looking at upgrading our project to Xcode 10.1 early in the new year, but notice that the latest binaries (5.15.0 versions) are built with Xcode 10, not Xcode 10.1.

Are there any plans to release Carthage binaries built for Xcode 10.1 soon?

@paulb777
Copy link
Member

5.15.0 was actually built with Xcode 9.2. We build Firebase with the earliest version that our infrastructure support since Apple typically supports linking binaries from older versions of Xcode but not from future versions. This allows us to support a wider range of developers.

We will likely move to building with Xcode 10.1 when it becomes required for App Store submission in March 2019.

In the meantime, we fully support usage of Xcode 10.1.

Why are you asking the question? Are you seeing an issue with using the Xcode 9.2-built binaries with Xcode 10.1?

@sraiteri
Copy link
Author

sraiteri commented Dec 27, 2018

Thanks @paulb777, completely understand the requirement here to build with Xcode 9.2 to improve the compatibility range.

The March 2019 push for App Store updates to be built with at least iOS 12.1 SDK is exactly what we're starting to prepare for, but are having issues specifically with the Carthage dependencies.

We re-publish the Firebase binary zips up to an internal equivalent of Carthage, so the URLs in the example have been obfuscated.

Firebase 5.15.0 Analytics & Messaging w/ Xcode 10.1

image

carthage bootstrap --platform iOS --no-use-binaries

*** Downloading binary-only framework firebase-analytics.json-5.15.0 at "https://host m:port/**/firebase-analytics.json-5.15.0.json"
*** Downloading binary-only framework firebase-messaging.json-5.15.0 at "https://host:port/**/firebase-messaging.json-5.15.0.json"
Incompatible Swift version - framework was built with 4.2 (swiftlang-1000.11.37.1 clang-1000.11.45.1) and the local version is 4.2.1 (swiftlang-1000.11.42 clang-1000.11.45.1).

Given the frameworks report as built with Swift 4.2, I had assumed that meant they were built using Xcode 10.0. They bootstrap perfectly fine in Xcode 10.0, but if I drop back to to Xcode 9.4.1, similar compatibility issues arise regarding Swift built framework versions:

Firebase 5.15.0 Analytics & Messaging w/ Xcode 9.4.1

image

carthage bootstrap --platform iOS --no-use-binaries

*** Downloading binary-only framework firebase-analytics.json-5.15.0 at "https://host m:port/**/firebase-analytics.json-5.15.0.json"
*** Downloading binary-only framework firebase-messaging.json-5.15.0 at "https://host:port/**/firebase-messaging.json-5.15.0.json"
Incompatible Swift version - framework was built with 4.2 (swiftlang-1000.11.37.1 clang-1000.11.45.1) and the local version is 4.1.2 (swiftlang-902.0.54 clang-902.0.39.2).

Using Firebase binary versions 5.12.0 are ok, because they are with Xcode 9.4.1 (Swift 4.1.2).

@paulb777
Copy link
Member

@sraiteri Thanks for the details. I'm not able to reproduce the issue with Xcode 10.1. A few strange things:

@sraiteri
Copy link
Author

@paulb777 - you were absolutely right on point #1. We had another external binary creep in last minute, and that ended up being the root cause of this issue (Carthage reporting here isn't great).

Dropping carthage dependencies back to just Firebase 5.15.0 components, I have no problems with carthage bootstrapping.

Thanks for your assistance on this one, sorry for the incorrect FR report!

@firebase firebase locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants