Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIAM init(actionText:actionURL:)' is deprecated #3545

Closed
xuaninbox opened this issue Aug 9, 2019 · 3 comments

Comments

@xuaninbox
Copy link

commented Aug 9, 2019

  • Xcode version: 10.3
  • Firebase SDK version: 6.6
  • Firebase Component: FirebaseInAppMessaging
  • Component version: 0.15.3

[REQUIRED] Step 3: Describe the problem

When using

InAppMessagingAction(actionText: modalMessage.actionButton?.buttonText, actionURL: actionURL)

warning says it's deprecated, I'm using customs InAppMessagingDisplay and I can't seem to find any replacement for this. Whats the best approach to fix this issue.

@google-oss-bot

This comment was marked as resolved.

Copy link
Collaborator

commented Aug 9, 2019

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.
@christibbs

This comment has been minimized.

Copy link
Collaborator

commented Aug 15, 2019

Hey Xuan, when we deprecated the initializer for InAppMessagingAction we failed to consider the custom InAppMessagingDisplay case. We'll un-deprecate it with the next release.

@christibbs christibbs closed this Aug 15, 2019
@paulb777

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

@christibbs Let's leave the issue open and close it with the PR that does the un-deprecation.

@paulb777 paulb777 reopened this Aug 15, 2019
@paulb777 paulb777 added this to the M55 milestone Aug 15, 2019
@christibbs christibbs closed this Aug 27, 2019
@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.