Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIAM init(actionText:actionURL:)' is deprecated #3545

Closed
xuaninbox opened this issue Aug 9, 2019 · 3 comments
Closed

FIAM init(actionText:actionURL:)' is deprecated #3545

xuaninbox opened this issue Aug 9, 2019 · 3 comments
Assignees
Labels
api: inappmessaging Firebase In App Messaging
Milestone

Comments

@xuaninbox
Copy link

xuaninbox commented Aug 9, 2019

  • Xcode version: 10.3
  • Firebase SDK version: 6.6
  • Firebase Component: FirebaseInAppMessaging
  • Component version: 0.15.3

[REQUIRED] Step 3: Describe the problem

When using

InAppMessagingAction(actionText: modalMessage.actionButton?.buttonText, actionURL: actionURL)

warning says it's deprecated, I'm using customs InAppMessagingDisplay and I can't seem to find any replacement for this. Whats the best approach to fix this issue.

@google-oss-bot

This comment has been minimized.

@christibbs
Copy link
Contributor

Hey Xuan, when we deprecated the initializer for InAppMessagingAction we failed to consider the custom InAppMessagingDisplay case. We'll un-deprecate it with the next release.

@paulb777
Copy link
Member

@christibbs Let's leave the issue open and close it with the PR that does the un-deprecation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: inappmessaging Firebase In App Messaging
Projects
None yet
Development

No branches or pull requests

5 participants