Remove unnecessary rmq database operations in unit tests. #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chliangGoogle Looks like the tests are still failing https://travis-ci.org/firebase/firebase-ios-sdk/jobs/607466145?utm_medium=notification&utm_source=github_status |
maksymmalyhin
approved these changes
Nov 5, 2019
| _testUtil = [[FIRMessagingTestUtilities alloc] initWithUserDefaults:defaults withRMQManager:YES]; | ||
| _mockMessaging = _testUtil.mockMessaging; | ||
| _mockInstanceID = _testUtil.mockInstanceID; | ||
| _messaging = _testUtil.messaging; |
There was a problem hiding this comment.
Maybe just remove _mockMessaging, _mockInstanceID, etc. and refer to _testUtil directly to avoid potential confusion in the future?
There was a problem hiding this comment.
this gonna be a big refactor, will probably do it in another CL.
There was a problem hiding this comment.
This is done in this PR.
|
xcode 10.2 seems to start failing but with some unrelated errors |
|
Failure is unrelated to Messaging. Also couldn't find the restart the test button anymore. I just submit the code for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DB operations between different test class that access the same database sometimes cause race conditions. Minimize DB initialization and operations to see if this resolves the issue.