-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTDB FSRWebSocket: suppress diagnostic error #7460
Conversation
@@ -1559,8 +1559,12 @@ - (void)safeHandleEvent:(NSStreamEvent)eventCode stream:(NSStream *)aStream | |||
|
|||
case NSStreamEventHasBytesAvailable: { | |||
SRFastLog(@"NSStreamEventHasBytesAvailable %@", aStream); | |||
|
|||
#pragma clang diagnostic push | |||
#pragma clang diagnostic ignored "-Wvla" | |||
const NSUInteger bufferSize = 2048; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks related to building for Objective-C++ instead of Objective C. Do you understand why that's happening?
Either way, it might be cleaner to address with a #define BUFFER_SIZE instead since all usages are in this file.
Coverage ReportAffected SDKs
Test Logs
|
Fix for cl/355486726 - g3 build error: