Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App check and storage, functions and RTDB support #7928

Merged
merged 196 commits into from
Apr 22, 2021
Merged

App check and storage, functions and RTDB support #7928

merged 196 commits into from
Apr 22, 2021

Conversation

maksymmalyhin
Copy link
Contributor

Open sourcing ongoing App Check SDK work. Changes in this PR have been previously reviewed in separate PRs in the private repo.

@maksymmalyhin
AppAttestation initial public API
1c175fa
@maksymmalyhin
Run ./scripts/style.sh
44479a9
@maksymmalyhin
Copyright
9b5f2aa
@maksymmalyhin
Cleanup
9e64cfa
@maksymmalyhin
Cleanup
e716fe2
@maksymmalyhin
Get token forcing refresh method
230caf0
@maksymmalyhin
Formatting
9bd817f
@maksymmalyhin
Forcing refresh samples
a389b58
@maksymmalyhin
Interop introduced
29779d7
@maksymmalyhin
Code samples for Interop
ddcb955
@maksymmalyhin
Run ./scripts/style.sh
299f9e5
@maksymmalyhin
Cleanup
a3ba5ff
@maksymmalyhin
Merge branch 'app-attestation' into mm/attestation-init
0422d89
@maksymmalyhin
TODOs and Copirights
bad426e
@maksymmalyhin
Fix build
d70d42f
@maksymmalyhin
Supported iOS versions
762bba4
@maksymmalyhin
Remove unnecessary bridging header
b637018
@maksymmalyhin
Run ./scripts/style.sh
6cf31d2
@maksymmalyhin
[WIP] DeviceCheckAttestationProvider as a subspec
8c622e3
@maksymmalyhin
cleanup
7fbc3ea
@maksymmalyhin
Add memory attributes to readonly properties
6cfbd56
@maksymmalyhin
Move FIRDeviceCheckAttestationProvider.h to private headers
31ae2d1
@maksymmalyhin
TODO for FirebaseAppAttestation/Core name
f92d4c7
@maksymmalyhin
Remove memory attributes from FIRAppAttestationToken properties
0f6661f
@maksymmalyhin
Merge pull request #622 from FirebasePrivate/mm/attestation-init
ba241f2 
App Attestation initial setup and public API definition
@maksymmalyhin
Merge branch 'master' into app-attestation
45f7e5e
@maksymmalyhin
FIRAppAttestationTests.testSetAttestationProviderFactory introduced
901a66c
@maksymmalyhin
FIRAppAttestationToken initializer
1dda651
@maksymmalyhin
Basic FIRLibrary implementation and FIRAppAttestationProviderFactory …
f631d83 
…ingestion.
@maksymmalyhin
Fix
5cdc32d
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-cla google-cla bot added the cla: yes label Apr 21, 2021
@google-oss-bot
Copy link

google-oss-bot commented Apr 21, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    SDK overall coverage changed from 56.88% (648562e) to 56.95% (9b22410) by +0.07%.

    Filename Base (648562e) Head (9b22410) Diff
    FConnection.m 27.56% 28.03% +0.46%
    FIRDatabaseComponent.m 17.39% 16.95% -0.44%
    FIRDatabaseConnectionContextProvider.m ? 96.47% ?
    FIRRetryHelper.m 88.37% 83.72% -4.65%
    FPersistentConnection.m 22.20% 21.69% -0.51%
    FRepo.m 13.73% 13.96% +0.23%
    FSRWebSocket.m 41.60% 39.95% -1.64%
    FWebSocketConnection.m 35.38% 42.75% +7.37%

  • FirebaseFunctions-iOS-FirebaseFunctions.framework

    SDK overall coverage changed from 33.63% (648562e) to 52.17% (9b22410) by +18.54%.

    Filename Base (648562e) Head (9b22410) Diff
    FIRFunctions.m 12.10% 54.10% +42.00%

  • FirebaseStorage-iOS-FirebaseStorage.framework

    SDK overall coverage changed from 59.59% (648562e) to 59.99% (9b22410) by +0.40%.

    Filename Base (648562e) Head (9b22410) Diff
    FIRStorage.m 75.30% 75.89% +0.59%
    FIRStorageTokenAuthorizer.m 100.00% 98.53% -1.47%

Test Logs

@maksymmalyhin maksymmalyhin marked this pull request as ready for review April 21, 2021 15:10
@maksymmalyhin
Copy link
Contributor Author

Fix for Functions Xcode 11 failure #7931.

@maksymmalyhin
Functions tests: fix Xcode 11 warnings (#7931)
4a70082 
* Functions tests: fix Xcode 11 warnings

* style
@maksymmalyhin
Copy link
Contributor Author

cc @kevinthecheung

@maksymmalyhin
App Check: token auto-refresh opt-out API (#769)
c39f029 
* FIRAppCheckSettings introduced (WIP)

* FIRAppCheckSettingsTests

* Style

* Make FIRAppCheckSettings instance per-app.

* FIRAppCheckTokenRefresher: use FIRAppCheckSettings.isTokenAutoRefreshEnabled (WIP)

* Tests

* Add public instance getters

* Fix analyzer warnings

* Fix testspec OS versions

* FIRAppCheckTokenRefresher expiration date update; tests

* FIRAppCheck.isTokenAutoRefreshEnabled implementation and tests

* style

* FIRAppCheck: Use specific types for variables in the default init

* More precise comments

* missing symbol

* FIRAppCheckSettings: remove defensive conditions from init.
@maksymmalyhin
Merge branch 'app-check-main' of github.com:firebase/firebase-ios-sdk…
9b22410 
… into app-check-main
@maksymmalyhin maksymmalyhin merged commit 47e0a98 into master Apr 22, 2021
@maksymmalyhin maksymmalyhin deleted the app-check-main branch April 22, 2021 01:01
@firebase firebase locked and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

@ncooke3 ncooke3 Awaiting requested review from ncooke3

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

Assignees

@paulb777 paulb777

Labels
api: database api: functions api: storage cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maksymmalyhin @google-oss-bot @paulb777 @ncooke3