Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Check: Token API for 3P use #8266

Merged
merged 20 commits into from
Jun 23, 2021
Merged

App Check: Token API for 3P use #8266

merged 20 commits into from
Jun 23, 2021

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 16, 2021 •
edited
Loading

  • Added Public Get Token API for 3P use
  • Refactored AppCheckTests.m to share testing infra between new public get token API and interop get token API
  • Added API-reviewed error enum
  • Add error handling for keychain related errors
  • Add tests for above addition

b/190653133

@google-cla google-cla bot added the cla: yes label Jun 16, 2021
maksymmalyhin
maksymmalyhin reviewed Jun 18, 2021
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM after adding tests.

FirebaseAppCheck/Sources/Public/FirebaseAppCheck/FIRAppCheck.h Outdated Show resolved Hide resolved
@ncooke3 ncooke3 marked this pull request as ready for review June 22, 2021 16:27
@maksymmalyhin maksymmalyhin self-requested a review June 22, 2021 17:11
maksymmalyhin
maksymmalyhin approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the clean tests!

FirebaseAppCheck/Sources/Core/Errors/FIRAppCheckErrorUtil.m Outdated Show resolved Hide resolved
FirebaseAppCheck/Sources/Core/Errors/FIRAppCheckHTTPError.m Outdated Show resolved Hide resolved
FirebaseAppCheck/Tests/Unit/AppAttestProvider/Storage/FIRAppAttestArtifactStorageTests.m Outdated Show resolved Hide resolved
maksymmalyhin
maksymmalyhin approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for the fixes!

@ncooke3 ncooke3 enabled auto-merge (squash) June 22, 2021 21:00
@ncooke3 ncooke3 merged commit 1803b00 into master Jun 23, 2021
@ncooke3 ncooke3 deleted the nc-appcheck-3p branch June 23, 2021 17:01
@ncooke3 ncooke3 mentioned this pull request Jun 23, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

Assignees
No one assigned
Labels
api: appcheck cla: yes public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ncooke3 @paulb777 @maksymmalyhin @google-oss-bot