Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add app ID header to Firebase Auth #9046

Merged
merged 6 commits into from Dec 8, 2021
Merged

Add app ID header to Firebase Auth #9046

merged 6 commits into from Dec 8, 2021

Conversation

rosalyntan
Copy link
Member

@rosalyntan rosalyntan commented Dec 3, 2021 •
edited

Add the X-Firebase-GMPID header to requests made from Firebase Auth.

@google-cla google-cla bot added the cla: yes label Dec 3, 2021
@google-oss-bot
Copy link

google-oss-bot commented Dec 3, 2021 •
edited

Coverage Report

Affected SDKs

  • FirebaseAuth-iOS-FirebaseAuth.framework

    SDK overall coverage changed from 68.24% (755f55a) to 68.24% (da53d68) by -0.00%.

    Filename Base (755f55a) Head (da53d68) Diff
    FIRAuthBackend.m 84.38% 84.21% -0.17%
    FIRUser.m 68.52% 68.54% +0.02%

Test Logs

@google-oss-bot
Copy link

google-oss-bot commented Dec 4, 2021 •
edited

Binary Size Report

Affected SDKs

  • FirebaseAuth

    Type Base (755f55a) Head (da53d68) Diff
    CocoaPods 1.03 MB 1.03 MB +8 B (+0.0%)

Test Logs

@rosalyntan rosalyntan changed the title Add user agent, heartbeat, and app ID headers to Firebase Auth Add app ID header to Firebase Auth Dec 7, 2021
@rosalyntan rosalyntan marked this pull request as ready for review December 7, 2021 21:29
@ncooke3 ncooke3 self-requested a review December 8, 2021 16:45
paulb777
paulb777 approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Presumably needs to wait for the backend to merge?

@rosalyntan
Copy link
Member Author

rosalyntan commented Dec 8, 2021 •
edited

LGTM. Presumably needs to wait for the backend to merge?

The auth backend is ready to handle the X-Firebase-GMPID header according to @avolkovi (but not the heartbeat header, which I've removed from this PR).

@rosalyntan rosalyntan merged commit c7f80c1 into master Dec 8, 2021
@rosalyntan rosalyntan deleted the rosalyntan.headers branch December 8, 2021 23:10
@ncooke3 ncooke3 mentioned this pull request Dec 9, 2021
Closed
@firebase firebase locked and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

@ncooke3 ncooke3 Awaiting requested review from ncooke3

Assignees
No one assigned
Labels
api: auth cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rosalyntan @google-oss-bot @paulb777