Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

Fix ‘replace current’ flag not being encoded #60

Merged
merged 1 commit into from Dec 15, 2016
Merged

Fix ‘replace current’ flag not being encoded #60

merged 1 commit into from Dec 15, 2016

Conversation

jenzz
Copy link
Contributor

@jenzz jenzz commented Dec 8, 2016

The replaceCurrent flag of a Job is currently being ignored since the JobCoder is not encoding it into the Bundle.

This fixes #59.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jenzz
Copy link
Contributor Author

jenzz commented Dec 8, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@ciarand ciarand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ciarand ciarand merged commit 67d671b into googlearchive:master Dec 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job.shouldReplaceCurrent() flag is always ignored
3 participants