Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc deprecated error on v5.3.1 #1112

Closed
shailen-naidoo opened this issue Aug 10, 2018 · 23 comments
Closed

grpc deprecated error on v5.3.1 #1112

shailen-naidoo opened this issue Aug 10, 2018 · 23 comments
Assignees

Comments

@shailen-naidoo
Copy link

There appears to be an issue with V5.3.1, i am getting a (node:14201) DeprecationWarning: grpc.load: Use the @grpc/proto-loader module with grpc.loadPackageDefinition instead but when i rollback to V5.3.0, there is no error

@google-oss-bot
Copy link
Contributor

Hmmm this issue does not seem to follow the issue template. Make sure you provide all the required information.

@google-oss-bot
Copy link
Contributor

Hey there! I couldn't figure out what this issue is about, so I've labeled it for a human to triage. Hang tight.

@0xNoSignal
Copy link

I seem to get the same error too (node:4226) DeprecationWarning: grpc.load: Use the @grpc/proto-loader module with grpc.loadPackageDefinition instead

How can I fix it?

@shailen-naidoo
Copy link
Author

@mhjey make sure you build have the correct version of node installed and rebuild the grpc dependancy according to that node version

@boygiandi
Copy link

(node:10278) DeprecationWarning: grpc.load: Use the @grpc/proto-loader module with grpc.loadPackageDefinition instead

Same here

@ghost
Copy link

ghost commented Feb 25, 2019

I am also having this error, I was working at home and it ran fine. Now I am trying to run the functions code on localhost on a public Wifi (I am at a library).

Will using public wifi, firewall rules or changing IP cause this error to happen?

Is there someway to reset the grpc server(s) on Mac OS?

@jperasmus
Copy link

Getting the same error, even on Node.js v11.10.0. Is it possible to reopen this issue since it is not resolved yet?

Briefly looked into it and the problem seems to be here:

return grpc.load(firestoreProtoFile, /*format=*/ 'proto', options);

It should be replaced by this:

const packageDefinition = protoLoader.loadSync(protoFileName, options);
const packageObject = grpcLibrary.loadPackageDefinition(packageDefinition);

The problem currently is that the options you can pass to the protoLoader.loadSync() method does not match up with the existing options, in particular, the convertFieldsToCamelCase: true option. I'm not sure what this should be changed to.

@JacobWeisenburger
Copy link

JacobWeisenburger commented Mar 19, 2019

DeprecationWarning: grpc.load: Use the @grpc/proto-loader module with grpc.loadPackageDefinition instead

Same here

firebase: v5.9.0
node: v11.10.0

@Obiwarn
Copy link

Obiwarn commented Apr 5, 2019

Same here. Please reopen!

@rsgowman rsgowman self-assigned this Apr 5, 2019
@rsgowman
Copy link
Member

rsgowman commented Apr 5, 2019

Reopened. I can confirm this on my system too. I'll see if I can get a fix in for this.

@rsgowman rsgowman reopened this Apr 5, 2019
@calibri87
Copy link

I get the same issue: this is my new stack overflow questions: https://stackoverflow.com/questions/55665271/firebase-functions-i-keep-getting-log-error-deprecationwarning-grpc-load-wh

@calibri87
Copy link

@rsgowman did you find a solution?

@rsgowman
Copy link
Member

@rsgowman did you find a solution?

Oops; sorry I dropped this. I had a sub-optimal solution out, but abandon it in favour of something a little nicer. I've now got that second version ready. Feel free to follow along: #1699

@JacobWeisenburger
Copy link

Any progress on this?

@mrsylerpowers
Copy link

@offg777

Feel free to follow along: #1699

@skypencil
Copy link

I am having the same error. I can write to firestore with no issues using admin credentials, but when I use firebase.firestore() as a client for end-user access I get:

(node:38909) DeprecationWarning: grpc.load: Use the @grpc/proto-loader module with grpc.loadPackageDefinition instead

@keng0o
Copy link

keng0o commented Apr 23, 2019

same here
node v10.15.3
firebase v5.9.4

@rsgowman
Copy link
Member

rsgowman commented May 1, 2019

This has just been finished here: #1669. (Which has been reworked further from #1699.) It should go out in the next release.

@rsgowman rsgowman closed this as completed May 1, 2019
@JacobWeisenburger
Copy link

JacobWeisenburger commented May 7, 2019

DeprecationWarning: grpc.load: Use the @grpc/proto-loader module with grpc.loadPackageDefinition instead
Still happening:
node v11.10.0
firebase v5.11.1

@wilhuff
Copy link
Contributor

wilhuff commented May 7, 2019

There is no Firebase 5.11.1. Perhaps you meant 5.10.1? If so that's the version from April 25, which predates @rsgowman's last comment.

@rsgowman
Copy link
Member

rsgowman commented May 7, 2019

@offg777: Hm. That one must've been in flight when this change landed. (And I can confirm, that 5.11.1 does indeed still have this deprecation error.) But try 6.0.0, just released. It should be good.

@rsgowman
Copy link
Member

rsgowman commented May 7, 2019

Looks like it's back to green now. (I think this was the problem: #1761)

@benwinding
Copy link

For me, the warning is removed when upgrading to firebase from 5.x -> 6.1.1

@firebase firebase locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests