Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The setting 'timestampsInSnapshots: true' is no longer required and should be removed #3879

Closed
wceolin opened this issue Oct 1, 2020 · 1 comment · Fixed by #3897
Closed
Assignees

Comments

@wceolin
Copy link

wceolin commented Oct 1, 2020

[REQUIRED] Describe your environment

  • Operating System version: MacOS 10.13.6
  • Browser version: Chrome 85.0.4183.121
  • Firebase SDK version: 7.22.0 / 7.21.0
  • Firebase Product: Firestore

[REQUIRED] Describe the problem

Steps to reproduce:

When we use the merge: true option in the settings (implemented by #3464), we get the error below even though we are NOT setting timestampsInSnapshots to true:

@firebase/firestore: Firestore (7.22.0): The setting 'timestampsInSnapshots: true' is no longer required and should be removed.

Relevant Code:

https://codesandbox.io/s/firebase-merge-settings-dxbx1?file=/src/firebase.js

firebase.firestore().settings({ merge: true });
@thebrianchen
Copy link

Thanks for filing the bug report with a repro! I've repro'd it on my machine as well. Will look into this deeper next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants