Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator warning banner text is not accessible #4867

Closed
markgoho opened this issue May 5, 2021 · 1 comment · Fixed by #4868
Closed

Emulator warning banner text is not accessible #4867

markgoho opened this issue May 5, 2021 · 1 comment · Fixed by #4868
Labels
api: auth testing-sdk testing with emulator

Comments

@markgoho
Copy link
Contributor

markgoho commented May 5, 2021

[REQUIRED] Describe your environment

n/a

[REQUIRED] Describe the problem

Steps to reproduce:

Run emulators, see warning banner

Relevant Code:

function attachBanner(): void {
const el = document.createElement('p');
const sty = el.style;
el.innerText =
'Running in emulator mode. Do not use with production credentials.';
sty.position = 'fixed';
sty.width = '100%';
sty.backgroundColor = '#ffffff';
sty.border = '.1em solid #000000';
sty.color = '#ff0000';
sty.bottom = '0px';
sty.left = '0px';
sty.margin = '0px';
sty.zIndex = '10000';
sty.textAlign = 'center';
el.classList.add('firebase-emulator-warning');
document.body.appendChild(el);
}

specifically:

sty.backgroundColor = '#ffffff';
sty.color = '#ff0000';

This color text on that background and at that font size produces a color contrast ratio of 3.99

There's an easy fix: make the color a darker red. PR #4868 fixes this issue.

@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@looptheloop88 looptheloop88 added the testing-sdk testing with emulator label May 7, 2021
@firebase firebase locked and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: auth testing-sdk testing with emulator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants