Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing type declarations in Auth interface #573

Closed
gonzaloriestra opened this issue Mar 19, 2018 · 7 comments
Closed

Missing type declarations in Auth interface #573

gonzaloriestra opened this issue Mar 19, 2018 · 7 comments
Assignees

Comments

@gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Mar 19, 2018

[REQUIRED] Describe your environment

  • Operating System version: Ubuntu 17.10
  • Firebase SDK version: 4.11.0
  • Firebase Product: Auth

[REQUIRED] Describe the problem

Steps to reproduce:

If you try to use the Auth function createUserAndRetrieveDataWithEmailAndPassword, Typescript complaints about it: Property 'createUserAndRetrieveDataWithEmailAndPassword' does not exist on type 'Auth'.

Relevant Code:

In firebase/index.d.ts the function createUserAndRetrieveDataWithEmailAndPassword should be defined in the Auth interface, as it is in auth-types/index.d.ts.

@gonzaloriestra
Copy link
Contributor Author

@gonzaloriestra gonzaloriestra commented Mar 19, 2018

The function signInAndRetrieveDataWithEmailAndPassword is also missing.

@gonzaloriestra gonzaloriestra changed the title Missing type declaration in Auth interface Missing types declaration in Auth interface Mar 19, 2018
@gonzaloriestra gonzaloriestra changed the title Missing types declaration in Auth interface Missing type declarations in Auth interface Mar 19, 2018
@bojeil-google
Copy link
Member

@bojeil-google bojeil-google commented Mar 19, 2018

@gonzaloriestra
Copy link
Contributor Author

@gonzaloriestra gonzaloriestra commented Mar 19, 2018

@bojeil-google Thanks, but shouldn't it be also defined in firebase/index.d.ts?

@bojeil-google
Copy link
Member

@bojeil-google bojeil-google commented Mar 19, 2018

Ah, i had forgotten about this file. There are a bunch of missing APIs there. Ok, will look into adding the missing APIs.

@Splaktar
Copy link

@Splaktar Splaktar commented Mar 21, 2018

Looks like this got solved in 9d00c6f

@gonzaloriestra
Copy link
Contributor Author

@gonzaloriestra gonzaloriestra commented Mar 21, 2018

@Splaktar I just added one function, but as bojeil-google said, there are more pending functions to add, like signInAndRetrieveDataWithEmailAndPassword.

@bojeil-google
Copy link
Member

@bojeil-google bojeil-google commented Mar 21, 2018

The missing ones should be available now.

@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants