Firestore triggers broken in emulator

[aputinski]

[REQUIRED] Version info

node: 10.15.3

firebase-functions: 3.0.0

firebase-tools: 7.0.0

firebase-admin: 8.0.0

[REQUIRED] Test case

https://github.com/aputinski/firebase-functions-test-case

[REQUIRED] Steps to reproduce

See README in repo above

[REQUIRED] Expected behavior

functions: Beginning execution of "onWrite"
functions: Finished "onWrite" in ~1s

[REQUIRED] Actual behavior

TypeError: Cannot read property 'eventType' of undefined

It looks like the data and context are being combined into the first argument

https://github.com/firebase/firebase-functions/blob/master/src/cloud-functions.ts#L242

Were you able to successfully deploy your functions?

N/A

[google-oss-bot]

I found a few problems with this issue:

• I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
• This issue does not seem to follow the issue template. Make sure you provide all the required information.

[thechenky]

Hi @aputinski do your functions run correctly when you deploy them?

[aputinski]

Yes. This is just for the emulator.

[thechenky]

Gotcha, thanks. I'm going to transfer this issue to the firebase-tools repo as emulation is done in the Firebase CLI.

[aputinski]

Thanks!

[thechenky]

@samtstern FYI, I think this is similar to the issue with RTDB triggers in emulation we discussed yesterday. Let me know how I can help!

[samtstern]

@aputinski this comes from using firebase-functions 3.x with the current emulators. We're working on a fix already, thank you for reporting!

[aputinski]

So if I use firebase-functions@2.3.1 with firebase-tools@7.0.0 everything will work?

[samtstern]

@aputinski yes I think it would.

[abeisgoat]

@aputinski I have nothing to contribute, but hi Adam! Glad to see you're still using Firebase after all these years :)

[aputinski]

@abeisgoat I'll always be a Firebaser 🔥