Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebase deploy has changed the maximum length of a function name from 63 chars to 62 chars #3493

Closed
dteirney opened this issue Jun 15, 2021 · 6 comments · Fixed by #3521
Closed
Assignees

Comments

@dteirney
Copy link

dteirney commented Jun 15, 2021

[REQUIRED] Environment info

firebase-tools: 9.13.0

Platform: macOS

[REQUIRED] Test case

https://github.com/dteirney/functions-samples/blob/master/quickstarts/pubsub-helloworld/functions/index.js

[REQUIRED] Steps to reproduce

Try to deploy a function with a name with 63 characters that previously would deploy, but no longer does.

[REQUIRED] Expected behavior

Deploy succeeds as with previous versions.

[REQUIRED] Actual behavior

Error: [object Object] function name(s) can only contain letters, numbers, hyphens, and not exceed 62 characters in length

@google-oss-bot
Copy link
Contributor

This issue does not have all the information required by the template. Looks like you forgot to fill out some sections. Please update the issue with more information.

@dteirney
Copy link
Author

Updated comment with function-samples forked and with a 63 char name added.

@dteirney dteirney changed the title firebase deploy has changed the maximum length of a function name from 63 chars to 62 chars firebase deploy has changed the maximum length of a function name from 64 chars to 62 chars Jun 15, 2021
@dteirney
Copy link
Author

dteirney commented Jun 15, 2021

Updated as we had a function name of 64 characters as well, which would previously deploy.

Nope, was 63, sorry.

@dteirney dteirney changed the title firebase deploy has changed the maximum length of a function name from 64 chars to 62 chars firebase deploy has changed the maximum length of a function name from 63 chars to 62 chars Jun 15, 2021
@samtstern
Copy link
Contributor

samtstern commented Jun 17, 2021

Hmmm the git blame on that line looks like this limitation has been in place for at least 2 years. @joehan or @inlined did yiou change something recently?

@samtstern
Copy link
Contributor

Based on the Cloud Functions console it looks like 63 is the correct limit, maybe this is a very old typo in our code:
Screen Shot 2021-06-17 at 12 14 19 PM

@inlined
Copy link
Member

inlined commented Jun 17, 2021

The validate function has been in place for years, but the call to that function was commented out until recently. We can up the limit if the backend will accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants