Run lifecycle hooks for specific codebases #6011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colerogers
approved these changes
Jun 20, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6011 +/- ##
==========================================
- Coverage 55.03% 55.02% -0.01%
==========================================
Files 339 339
Lines 23220 23222 +2
Branches 4746 4747 +1
==========================================
Hits 12779 12779
- Misses 9311 9313 +2
Partials 1130 1130
☔ View full report in Codecov by Sentry. |
|
The issue with hooks not running when deploying individual functions did not exist before! That's a new regression introduced by this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6002. Further investigation has surfaced another issue where deploying individual functions specified by the
--onlyflag will not run any predeploy hooks, but will table this issue for another fix.