Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove public directory from hosting emulator for frameworks #6674

Merged
merged 10 commits into from Jan 23, 2024

Conversation

leoortizz
Copy link
Member

Description

Should fix #6377

Scenarios Tested

Sample Commands

@leoortizz leoortizz changed the title change public directory for frameworks dev server with emulator remove public directory from hosting emulator for frameworks Jan 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d0972f7) 54.17% compared to head (873b647) 54.14%.

Files Patch % Lines
src/frameworks/index.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6674      +/-   ##
==========================================
- Coverage   54.17%   54.14%   -0.03%     
==========================================
  Files         347      347              
  Lines       24135    24133       -2     
  Branches     4978     4978              
==========================================
- Hits        13075    13068       -7     
- Misses       9859     9863       +4     
- Partials     1201     1202       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leoortizz leoortizz marked this pull request as ready for review January 9, 2024 18:27
@leoortizz leoortizz enabled auto-merge (squash) January 23, 2024 14:18
@leoortizz leoortizz merged commit 7717b83 into master Jan 23, 2024
35 checks passed
@leoortizz leoortizz deleted the leoortizz_publicDirFrameworkDev branch January 23, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emulator doesn't work with demo projects + web frameworks
3 participants