Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(database): remove duplicate wording in documentation #10229

Merged
merged 2 commits into from Feb 9, 2023

Conversation

martin-ksti
Copy link
Contributor

Description

Removed two words in function description which were too many there.

@google-cla
Copy link

google-cla bot commented Jan 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@russellwheatley russellwheatley changed the title textual error corrected docs(database): remove duplicate wording in documentation Jan 17, 2023
@russellwheatley
Copy link
Member

Hey @martin-ksti, do you mind signing the CLA agreement so we can get this PR merged?

@russellwheatley
Copy link
Member

Any chance you can sign the CLA, @martin-ksti? 😄

@martin-ksti
Copy link
Contributor Author

martin-ksti commented Jan 30, 2023 via email

@russellwheatley
Copy link
Member

@martin-ksti please follow instructions on how to sign CLA 👍

@martin-ksti
Copy link
Contributor Author

martin-ksti commented Feb 8, 2023

I had already signed the CLA - the only thing missing was:
"🔁 New Contributors: Update this check after signing the CLA by clicking here." for a rescan ...
🤦‍♂️

@russellwheatley russellwheatley merged commit d4feb22 into firebase:master Feb 9, 2023
@firebase firebase locked and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants