Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloud_firestore): startAfterDocument with where a DocumentReference throws #10339

Merged

Conversation

agent3bood
Copy link
Contributor

@agent3bood agent3bood commented Jan 27, 2023

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

closes #10338

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

The command melos run analyze fails in packages not related to my PR, see bellow.

$ melos exec
  └> dart analyze . --fatal-infos
     └> FAILED (in 4 packages)
        └> cloud_firestore_odm (with exit code 1)
        └> cloud_firestore_odm_example (with exit code 1)
        └> cloud_firestore_odm_generator (with exit code 1)
        └> cloud_firestore_odm_generator_integration_test (with exit code 1)

@agent3bood agent3bood changed the title [cloud_firestore] startAfterDocument with where a DocumentReference throws fix(cloud_firestore): startAfterDocument with where a DocumentReference throws Jan 27, 2023
Copy link
Contributor

@Lyokone Lyokone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but tests should be moved to integration testing.

@Lyokone Lyokone self-assigned this Jan 30, 2023
@Lyokone Lyokone force-pushed the fix/startAfterDocument_encode_values branch from 96a9ca0 to 87a541f Compare February 2, 2023 09:54
@Lyokone
Copy link
Contributor

Lyokone commented Feb 2, 2023

Rebased the branch on master to get CI working with Flutter 3.7

@Lyokone Lyokone merged commit 8224acb into firebase:master Feb 2, 2023
@Lyokone
Copy link
Contributor

Lyokone commented Feb 2, 2023

Thanks for your help :)

@firebase firebase locked and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [cloud_firestore] startAfterDocument with where a DocumentReference throws
3 participants