Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messaging, ios): badge is in the message, not the notification #10470

Merged
merged 2 commits into from Feb 21, 2023

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Feb 16, 2023

Description

Print out the message in Xcode. You can see the badge is in the message, not the alert dictionary.
Screenshot 2023-02-16 at 10 16 14

To test, I sent a message with a badge:

admin
.messaging()
.sendToDevice(
  [iosToken],
  {
    data: {
      something:'else',
    },
    notification: {
      title: 'A great title',
      body: 'Great content',
      badge: '3'
    },
  },
  {
    // Required for background/terminated app state messages on iOS
    contentAvailable: true,
    // Required for background/terminated app state messages on Android
    priority: 'high',
  }
)

Print out print('${message.notification?.apple?.toMap()}'); on the incoming message from onMessage. You can see the badge is now correctly on the AppleNotification instance.

{badge: 3, subtitle: null, subtitleLocArgs: [], subtitleLocKey: null, imageUrl: null, sound: null}

I also had to convert the int type to a string in the underlying implementation as badge is a String? type and the encoding silently fails if I don't. See implementation

Related Issues

closes #9533

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley merged commit cf28267 into master Feb 21, 2023
@russellwheatley russellwheatley deleted the messaging-9533 branch February 21, 2023 14:01
@firebase firebase locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_messaging] Why ios badge data is managed in alert ?
3 participants