Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore, web): fix an issue in the update method using FieldValue.arrayUnion or Map #10481

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Feb 17, 2023

Description

Even with #10461 some tests do not run on CI.

The test testing this behavior was only failing locally.

Related Issues

closes #10475 #10478

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone changed the title fix(firestore, web): fix an issue in the update method using FieldValue.arrayUnion fix(firestore, web): fix an issue in the update method using FieldValue.arrayUnion or Map Feb 17, 2023
@Lyokone Lyokone changed the title fix(firestore, web): fix an issue in the update method using FieldValue.arrayUnion or Map fix(firestore, web): fix an issue in the update method using FieldValue.arrayUnion or Map Feb 17, 2023
@Lyokone Lyokone merged commit d1998aa into master Feb 17, 2023
@Lyokone Lyokone deleted the fix/10475 branch February 17, 2023 07:48
@firebase firebase locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [cloud_firestore] / [cloud_firestore_web] Error on update with FieldValue.arrayUnion()
3 participants