Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(functions): add support for 2nd gen functions #10545

Merged
merged 15 commits into from Mar 22, 2023
Merged

feat(functions): add support for 2nd gen functions #10545

merged 15 commits into from Mar 22, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Mar 1, 2023

Description

There are now 2 new functions,
httpsCallableFromUrl and httpsCallableFromUri that can take a String Url or a parsed Uri to use a 2nd gen Cloud Function.

Related Issues

#10541

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone marked this pull request as ready for review March 2, 2023 08:25
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last bit I noticed 😅

@Lyokone Lyokone merged commit 204ba39 into master Mar 22, 2023
11 of 13 checks passed
@Lyokone Lyokone deleted the feat/10541 branch March 22, 2023 17:12
@firebase firebase locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants