feat(auth): improve error handling when Email enumeration feature is on #10591
+37
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellwheatley
approved these changes
Mar 16, 2023
lesnitsky
reviewed
Mar 16, 2023
| } | ||
| } | ||
| // This code happens when using Enumerate Email protection | ||
| // The error code is only returned in a String on Android | ||
| if (additionalData?['message'] == 'INVALID_LOGIN_CREDENTIALS' || |
There was a problem hiding this comment.
do we have a list of error codes somewhere? would it make sense to have an enum with all errors?
something like
enum FirebaseAuthErrorCode {
invalidLoginCredentials('INVALID_LOGIN_CREDENTIALS');
final String code;
const FirebaseAuthErrorCode(this.code);
}potentially out of scope of this PR, but could be useful
There was a problem hiding this comment.
Couldn't find it in the Firebase Android or iOS repository 🤔 I will ask next call with Firebase 👍
lesnitsky
approved these changes
Mar 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently cannot be tested since we cannot activate this feature on the emulator.
The error code is properly returned on Web. But is not correctly parsed on iOS (it's hidden in a details object), and is not returned on Android (only available in a String).
Related Issues
#10588
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?