Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): improve error handling when using beforeSignIn functions blocks sign in #10611

Merged
merged 1 commit into from Mar 16, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Mar 16, 2023

Description

Currently cannot be tested since we cannot activate this feature on the emulator.

The error code is properly returned on Web. But is not correctly parsed on iOS (it's hidden in a details object), and is not returned on Android (only available in a String).

Related Issues

fix #10589

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone merged commit b48e095 into master Mar 16, 2023
13 checks passed
@Lyokone Lyokone deleted the fix/10589 branch March 16, 2023 12:36
@firebase firebase locked and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_auth] Auth blocking functions in iOS throw an incorrect result
3 participants