Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, web): fix support for hot reload with multiple named instances when using an emulator on Web #10766

Merged
merged 3 commits into from Apr 13, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Apr 11, 2023

Description

This is the output in the console:
Screenshot 2023-04-11 at 09 35 32

Related Issues

closes #10763

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix(auth, web): fix support for hot relod with multiple named instance when using an emulator on Web fix(auth, web): fix support for hot reload with multiple named instances when using an emulator on Web Apr 11, 2023
@Lyokone Lyokone merged commit b5de275 into master Apr 13, 2023
12 of 13 checks passed
@Lyokone Lyokone deleted the fix/10763 branch April 13, 2023 11:59
@firebase firebase locked and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_auth] WEB - using multiple emulators messes with firebaseEmulatorOrigin
4 participants