Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-check): support for getLimitedUseToken() API #11091

Merged
merged 16 commits into from Jun 14, 2023

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jun 6, 2023

Description

Done

  • support for getLimitedUseToken() on apple, android and web.
  • updated e2e tests to check for exception as getLimitedUseToken() & getToken() tests won't work without debug token pasted into Firebase console so we check they returned a FirebaseException.
  • Downgraded app check android build gradle version for app check example as it wouldn't compile.
  • Updated web configuration for app check example so it will work.

Related Issues

closes #11031

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title feat(app-check) getLimitedUseAppCheckToken() API feat(app-check): support for getLimitedUseAppCheckToken() API Jun 6, 2023
@russellwheatley russellwheatley marked this pull request as ready for review June 9, 2023 09:58
@russellwheatley russellwheatley changed the title feat(app-check): support for getLimitedUseAppCheckToken() API feat(app-check): support for getLimitedUseToken() API Jun 12, 2023
@russellwheatley russellwheatley merged commit 9db9326 into master Jun 14, 2023
18 checks passed
@russellwheatley russellwheatley deleted the app-check-11031 branch June 14, 2023 07:34
khanliKU pushed a commit to khanliKU/flutterfire that referenced this pull request Jun 18, 2023
@firebase firebase locked and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_app_check] Add support for getLimitedUseAppCheckToken
4 participants