Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): allow up to 30 Filter queries within Filter.or() & Filter.and() #11140

Merged
merged 12 commits into from
Jul 11, 2023

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jun 15, 2023

Description

Able to create 30 conjunctive and disjunctive queries using Filter API. Not able to do the same with array-contains-any, where-in or where-not-in using where() API. See related issue.

Related Issues

related to #11085

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Filter? filter27,
Filter? filter28,
Filter? filter29,
Filter? filter30,
Copy link

@JonasWanke JonasWanke Jun 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these new parameters get forwarded to the _generateFilter(…) call? Currently, they are ignored.

Same for and(…) below.

Also, the comment above still mentions 10 being the limit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up 👍 . I've added to _generateFilter().

@exaby73 exaby73 self-requested a review July 11, 2023 09:44
@russellwheatley russellwheatley merged commit e1f0064 into master Jul 11, 2023
20 checks passed
@russellwheatley russellwheatley deleted the firestore-11085 branch July 11, 2023 09:47
@firebase firebase locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants