-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(firestore): allow up to 30 Filter queries within Filter.or()
& Filter.and()
#11140
Conversation
Filter? filter27, | ||
Filter? filter28, | ||
Filter? filter29, | ||
Filter? filter30, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these new parameters get forwarded to the _generateFilter(…)
call? Currently, they are ignored.
Same for and(…)
below.
Also, the comment above still mentions 10 being the limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up 👍 . I've added to _generateFilter()
.
Description
Able to create 30 conjunctive and disjunctive queries using
Filter
API. Not able to do the same witharray-contains-any
,where-in
orwhere-not-in
usingwhere()
API. See related issue.Related Issues
related to #11085
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?