Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_storage): updated firebase_storage_web to allow http package dependency range '>=0.13.0 <2.0.0'. Fixes dependency resolution. #11158

Merged
merged 3 commits into from Jun 26, 2023

Conversation

OutdatedGuy
Copy link
Contributor

Description

Updated the http package to v1.0.0. This will make the plugin compatible with all the packages that use the latest v1.0.0 of the http package.

Related Issues

Fixes #11073

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@OutdatedGuy OutdatedGuy changed the title chore: updated http package to v1.0.0 chore(firebase_storage_web): updated http package to v1.0.0 Jun 20, 2023
@sparrow001
Copy link

Seems like there is a clear domino effect taking place, tests are failing because they cant install the packages to test because of the version conflict

Quite ironic

@OutdatedGuy
Copy link
Contributor Author

Seems like there is a clear domino effect taking place, tests are failing because they cant install the packages to test because of the version conflict

Quite ironic

Yep, as all packages use pub reference instead of path reference. Updating any major dependency seems to fails all the tests.

Unfortunately I don't know how to overcome that issue.

Co-authored-by: Felix Angelov <felangelov@gmail.com>
@sparrow001
Copy link

Does this mean this will be pushed soon???? :0

Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM seems like the one failing test could be flaky so I’d try re-running it.

@russellwheatley russellwheatley changed the title chore(firebase_storage_web): updated http package to v1.0.0 fix(firebase_storage): updated firebase_storage_web to allow http package dependency range '>=0.13.0 <2.0.0'. Fixes dependency resolution. Jun 26, 2023
@russellwheatley russellwheatley merged commit 7d0ca25 into firebase:master Jun 26, 2023
18 of 19 checks passed
@OutdatedGuy OutdatedGuy deleted the patch-1 branch June 26, 2023 13:12
@OutdatedGuy
Copy link
Contributor Author

OutdatedGuy commented Jun 26, 2023

Why is this test still running even after 5 hours? @russellwheatley @lesnitsky

Screenshot 2023-06-26 at 6 47 21 PM

@sparrow001
Copy link

Seems like a good old GitHub bug. Its stuck on terminating all the processes, so its safe to assume the actual test was successful at least.

@russellwheatley
Copy link
Member

Why is this test still running even after 5 hours? @russellwheatley @lesnitsky

Screenshot 2023-06-26 at 6 47 21 PM

No idea, it passed but never left the "in progress" state. Just a bug in Github Actions somewhere.

@firebase firebase locked and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_storage] Version solving failed for most recent http version (v1.0.0)
5 participants