New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(firebase_storage): updated firebase_storage_web
to allow http
package dependency range '>=0.13.0 <2.0.0'. Fixes dependency resolution.
#11158
Conversation
http
package to v1.0.0http
package to v1.0.0
Seems like there is a clear domino effect taking place, tests are failing because they cant install the packages to test because of the version conflict Quite ironic |
Yep, as all packages use pub reference instead of path reference. Updating any major dependency seems to fails all the tests. Unfortunately I don't know how to overcome that issue. |
Co-authored-by: Felix Angelov <felangelov@gmail.com>
Does this mean this will be pushed soon???? :0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM seems like the one failing test could be flaky so I’d try re-running it.
http
package to v1.0.0firebase_storage_web
to allow http
package dependency range '>=0.13.0 <2.0.0'. Fixes dependency resolution.
Why is this test still running even after 5 hours? @russellwheatley @lesnitsky |
Seems like a good old GitHub bug. Its stuck on terminating all the processes, so its safe to assume the actual test was successful at least. |
No idea, it passed but never left the "in progress" state. Just a bug in Github Actions somewhere. |
Description
Updated the http package to
v1.0.0
. This will make the plugin compatible with all the packages that use the latestv1.0.0
of the http package.Related Issues
Fixes #11073
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?