-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [firebase_auth] error.credential is always null, OAuthProvider.credentialFromError doesn't exist #11164
Comments
Thanks for the report and analysis. /cc @Lyokone for thoughts. |
Thanks for the report, I'm going to have a look to add this |
This is happening for me too. The credential property is always null |
same here |
@Lyokone @darshankawar any update? |
Downgrading firebase_auth to 4.6.1 bypasses this as far as I can see. I do get the e-mail in the exception itself (e.email). |
Do we have any updates on this? |
Any updates on this? Blocked on this |
I'm blocked on this and I can't update the rest of the libraries because of this. |
@russellwheatley do you know anything about a fix for this? |
@darshankawar do you know anything about a fix for this? |
Is it erroring across all platforms or is this specific to web platform? |
@russellwheatley I encounter this on mobile platform while auth using SMS for example. If the user is already linked to that phone number I'm not getting the credential from the error to log in to the existing account.
e.credential is always null and user will be stuck. The last working version of firebase auth is this one: |
@russellwheatley Have encountered this on Apple sign-in and Facebook sign-in when linking providers. This for me is for both iOS and Android |
@russellwheatley @darshankawar
The sign in It's not working anymore. You get this |
@russellwheatley @darshankawar |
@MirceaX2Mobile - could you create a new issue as this is a different problem and could you also provide a repro. Thanks. |
@russellwheatley If it is should I open a new one? |
@MirceaX2Mobile - if you're experiencing this issue trying to link an anonymous account with an email account, then it is that issue. |
@MirceaX2Mobile In my case it's using Phone Authentication, but i think it has the same core logic. I will mention that there. |
Bug report
When attempting account linking in cases of
email-already-in-use
, I noticed thaterror.credential
is now alwaysnull
.I can see the
error.credential
prop has been removed fromAuthError
, but it still shown as existing inFirebaseAuthException
in thefirebase_auth
package.Here we are told by one of the Firebase team to replace usage of
error.credential
with the OAuthProvider.credentialFromError method.However,
credentialFromError
doesn't exist on any of theOAuthProvider
interfaces infirebase_auth
.Expected behavior
OAuthProvider.credentialFromError
should exist infirebase_auth
FirebaseAuthException
should removecredential
and match theAuthError
interfaceVersions
firebase_auth: ^4.6.1
The text was updated successfully, but these errors were encountered: