Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(crashlytics): illustrate different methods for recording crashes #11275

Merged
merged 1 commit into from Jul 13, 2023

Conversation

russellwheatley
Copy link
Member

Description

see title.

Related Issues

Replaces this PR: #10772

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title docs(crashlytics): illustrate different methods of recording crashes docs(crashlytics): illustrate different methods for recording crashes Jul 13, 2023
@russellwheatley russellwheatley merged commit d00c3ed into master Jul 13, 2023
10 checks passed
@russellwheatley russellwheatley deleted the update-crashlytics-docs branch July 13, 2023 11:07
@russellwheatley
Copy link
Member Author

Hi @kevinthecheung - would be nice to have a new deployment of Firebase docs site so this is refreshed. Thanks.

}
// If you want to record a "non-fatal" exception, use `FirebaseCrashlytics.instance.recordFlutterError` instead
const fatalError = true;
FlutterError.onError = (errorDetails) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this condition have any sense since it is const value?

@firebase firebase locked and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants