Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, android): Fix crash on Android where detaching from engine. #11296

Merged
merged 1 commit into from Jul 18, 2023

Conversation

note11g
Copy link
Contributor

@note11g note11g commented Jul 17, 2023

Description

Fix crash on Android where detaching from engine.

Related Issues

fix #11291

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla
Copy link

google-cla bot commented Jul 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Lyokone
Copy link
Contributor

Lyokone commented Jul 17, 2023

Could your sign the CLA @note11g ?

@note11g
Copy link
Contributor Author

note11g commented Jul 17, 2023

@Lyokone I signed to the CLA after the warning appeared above. (rescaned. cla status changed.)

@Lyokone
Copy link
Contributor

Lyokone commented Jul 18, 2023

Thanks for your contribution :)

@Lyokone Lyokone merged commit d0a3733 into firebase:master Jul 18, 2023
21 of 22 checks passed
@firebase firebase locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_auth] Unable to destroy activity java.lang.NullPointerException
3 participants