fix(auth): set the tenant id on iOS FIRAuth instance
#11427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rexios80
changed the title
…eon-set-tenant-id-ios
|
Our iOS users reported saying that they cannot login, while everything is fine on the Android side. After further investigation, tenant id was not set when sending the request the login. The issue is fixed after using the above commit. Please consider merging this as soon as possible. Thank you. |
|
@russellwheatley sorry for the ping but this is a very minor change and quite urgent. Can we get this merged ASAP? |
russellwheatley
changed the title
russellwheatley
approved these changes
Aug 10, 2023
|
@Rexios80 - I'll make sure this is in the next release 👍 |
|
@Rexios80 - do you mind merging with master branch, please? |
…eon-set-tenant-id-ios
russellwheatley
changed the title
FIRAuth instance
exaby73
approved these changes
Aug 14, 2023
khanliKU
pushed a commit
to khanliKU/flutterfire
that referenced
this pull request
Aug 18, 2023
exaby73
pushed a commit
that referenced
this pull request
Sep 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like this got missed with the migration to pigeon
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?