Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): allow FieldPath.documentId as a field argument in queries #11443

Merged
merged 4 commits into from
Aug 15, 2023

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Aug 10, 2023

Description

see title.

Related Issues

fixes #11422

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix(firestore): allow documentId as a field argument fix(firestore): allow FieldPath.documentId as a field argument in queries Aug 10, 2023
@russellwheatley russellwheatley merged commit 4e01a9d into master Aug 15, 2023
23 checks passed
@russellwheatley russellwheatley deleted the firestore-11422 branch August 15, 2023 08:25
khanliKU pushed a commit to khanliKU/flutterfire that referenced this pull request Aug 18, 2023
@firebase firebase locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [cloud_firestore] Cannot use FieldPath.documentId in Filter
3 participants