Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_analytics): support getSessionId for android and apple platforms #11478

Merged
merged 5 commits into from Sep 12, 2023

Conversation

exaby73
Copy link
Contributor

@exaby73 exaby73 commented Aug 16, 2023

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@exaby73 exaby73 marked this pull request as ready for review September 3, 2023 09:47
@russellwheatley russellwheatley changed the title feat(firebase_analytics): add getSessionId feat(firebase_analytics): support getSessionId for android and apple platforms Sep 12, 2023
@russellwheatley russellwheatley merged commit 13aaf03 into master Sep 12, 2023
25 of 26 checks passed
@russellwheatley russellwheatley deleted the feat/get_session_id branch September 12, 2023 13:49
@piyushlimited
Copy link

Using Flutter with version - 3.13.6 and Firebase Analytics Package - 10.5.0
It's started throwing error and not allowing to run or build the app anymore.

Error -
/Users/******/.pub-cache/hosted/pub.dev/firebase_analytics-10.5.0/android/src/main/java/io/flutter/plugins/firebase/analytics/FlutterFirebaseAnalyticsPlugin.java:166: error: cannot find symbol
taskCompletionSource.setResult(Tasks.await(analytics.getSessionId()));
^
symbol: method getSessionId()
location: variable analytics of type FirebaseAnalytics
1 error

Please let me know what need to be done to solve the same.

@exaby73
Copy link
Contributor Author

exaby73 commented Oct 3, 2023

Hello @piyushlimited. Make sure your firebase_core version is up to date

@firebase firebase locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants