fix(firebase_auth): Update the position of the auth parameter for RecaptchaVerifier in the interop code to reflect changes in firebase-js-sdk
#11514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellwheatley
changed the title
RecaptchaVerifier in the interop code to reflect changes in firebase-js-sdk
russellwheatley
approved these changes
Aug 29, 2023
exaby73
approved these changes
Aug 29, 2023
exaby73
pushed a commit
that referenced
this pull request
Sep 3, 2023
…captchaVerifier` in the interop code to reflect changes in `firebase-js-sdk` (#11514)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The position of the auth parameter in the RecaptchaVerifier was changed on the firebase-js-sdk (see: https://github.com/firebase/firebase-js-sdk/pull/7326/files), this PR updates the interop code to reflect that.
Related Issues
Phone sign-in on web is currently broken due to the above issue.
Fixes: #11485
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?