Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(messaging, android): removed unsafe & deprecated API. E.g. LocalBroadcastManager replaced by LiveData #11659

Merged
merged 9 commits into from Oct 3, 2023

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Oct 2, 2023

Description

This effects the refreshToken & onMessage API. For completeness, I also tested the onMessageOpenedApp & the onBackgroundMessage handler. They all worked as intended.

List of changes made:

  • Removed LocalBroadcastManager API in favour of the recommended LiveData API.
  • Updated AGP to v8.
  • Removed Jetifier as it is not needed anymore.
  • deprecated sendMessage() as the underlying android API send() is deprecated and will be decommissioned in June 2024.
  • Update some API according to android studio linting for unchecked API.

Related Issues

Addressed some messaging warnings for this issue: #8073

Still need to return and work on the JobIntentService which has a number of deprecated API.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley merged commit 690160f into master Oct 3, 2023
25 checks passed
@russellwheatley russellwheatley deleted the messaging-8073 branch October 3, 2023 13:24
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Oct 29, 2023
@firebase firebase locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants