Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): fix clashing filenames between Auth and Firestore #11731

Merged
merged 8 commits into from Oct 19, 2023
Merged

fix(ios): fix clashing filenames between Auth and Firestore #11731

merged 8 commits into from Oct 19, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Oct 18, 2023

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

closes #11720

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone mentioned this pull request Oct 18, 2023
Closed
exaby73
exaby73 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@exaby73 exaby73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/cloud_firestore/cloud_firestore/example/lib/main.dart Show resolved Hide resolved
@Lyokone Lyokone merged commit 8770caf into master Oct 19, 2023
23 checks passed
@Lyokone Lyokone deleted the fix/11720 branch October 19, 2023 07:22
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Oct 29, 2023
@Lyokone @LocLt-Mobile
fix(ios): fix clashing filenames between Auth and Firestore (firebase…
fc5e8f4 
…#11731)

* fix(ios): fix clashing filenames between Auth and Firestore

* android

* dart

* windows

* windows

* analyze

* macos

* windows
@firebase firebase locked and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@russellwheatley russellwheatley russellwheatley approved these changes

@exaby73 exaby73 exaby73 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_auth] 'PigeonParser.h' file not found in iOS
3 participants
@Lyokone @russellwheatley @exaby73