Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core, windows): remove unused map of string that was causing a crash #11745

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Oct 20, 2023

Description

Before we used a STATIC compilation of the different Windows plugins, we needed to recreate the Firebase App in each plugin. I've removed this stale code that we don't use anymore.

Related Issues

closes #11684

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link

@P-ro-VL P-ro-VL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull is really helpful. I tried to delete some lines of code like this and everything worked normally.

@Lyokone Lyokone merged commit 895da05 into master Oct 23, 2023
22 of 24 checks passed
@Lyokone Lyokone deleted the fix/11684 branch October 23, 2023 08:19
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Oct 29, 2023
@firebase firebase locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_core] Debug connection gets lost
4 participants