Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth, windows): add Windows support for Google Sign In #11861

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Nov 10, 2023

Description

Fix Windows' parsing of Providers argument, and add in the example app how to use google_sign_in_dartio in order to get the correct values.

Related Issues

closes #11752

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone merged commit cde57d0 into master Nov 10, 2023
18 of 21 checks passed
@Lyokone Lyokone deleted the feat/googlesignin-windows branch November 10, 2023 09:42
@firebase firebase locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛[auth] : Windows desktop crashes when google signin is attempted.
3 participants