Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): return email address if one is returned by the auth exception #11978

Merged
merged 9 commits into from Dec 12, 2023

Conversation

russellwheatley
Copy link
Member

Description

  • Add email address to exception
  • Update auth example app with Facebook login.

Related Issues

fixes #11845

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley merged commit ceee304 into master Dec 12, 2023
20 of 21 checks passed
@russellwheatley russellwheatley deleted the auth-11845 branch December 12, 2023 15:29
@ablbol
Copy link

ablbol commented Dec 12, 2023

Please ensure that the exception also returns the "credential" property if it exists. This is important for linking accounts.
Thanks for your help.

@firebase firebase locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants